[llvm-commits] [llvm] r146801 - in /llvm/trunk: include/llvm/MC/MCStreamer.h lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp lib/MC/MCAsmStreamer.cpp lib/MC/MCLoggingStreamer.cpp lib/MC/MCNullStreamer.cpp lib/MC/MCParser/COFFAsmParser.cpp lib/MC/MCStr

[Evan Cheng]

Hi Rafael,

Chandler is absolutely right. Please revert the patch.

Thanks,

Evan

On Dec 20, 2011, at 2:03 AM, Chandler Carruth wrote:

> On Fri, Dec 16, 2011 at 5:14 PM, Rafael Espindola <rafael.espindola at gmail.com> wrote:
> Modified: llvm/trunk/lib/MC/WinCOFFStreamer.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WinCOFFStreamer.cpp?rev=146801&r1=146800&r2=146801&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/WinCOFFStreamer.cpp (original)
> +++ llvm/trunk/lib/MC/WinCOFFStreamer.cpp Fri Dec 16 19:14:52 2011
> @@ -32,6 +32,9 @@
>  #include "llvm/Support/ErrorHandling.h"
>  #include "llvm/Support/TargetRegistry.h"
>  #include "llvm/Support/raw_ostream.h"
> +
> +#include "../Target/X86/MCTargetDesc/X86FixupKinds.h"
> +
> 
> This is a pretty egregious layering violation. Please fix or revert, this causes all kinds of problems with improper dependencies between various components.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111220/cae33586/attachment.html>