<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Rafael,<div><br></div><div>Chandler is absolutely right. Please revert the patch.</div><div><br></div><div>Thanks,</div><div><br></div><div>Evan</div><div><br><div><div>On Dec 20, 2011, at 2:03 AM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Fri, Dec 16, 2011 at 5:14 PM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":4e4">Modified: <span class="il">llvm</span>/trunk/lib/<span class="il">MC</span>/WinCOFFStreamer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WinCOFFStreamer.cpp?rev=146801&r1=146800&r2=146801&view=diff" target="_blank" class="cremed">http://<span class="il">llvm</span>.org/viewvc/<span class="il">llvm</span>-project/<span class="il">llvm</span>/trunk/lib/<span class="il">MC</span>/WinCOFFStreamer.cpp?rev=146801&r1=146800&r2=146801&view=diff</a><br>
==============================================================================<br>
--- <span class="il">llvm</span>/trunk/lib/<span class="il">MC</span>/WinCOFFStreamer.cpp (original)<br>
+++ <span class="il">llvm</span>/trunk/lib/<span class="il">MC</span>/WinCOFFStreamer.cpp Fri Dec 16 19:14:52 2011<br>
@@ -32,6 +32,9 @@<br>
#include "<span class="il">llvm</span>/Support/ErrorHandling.h"<br>
#include "<span class="il">llvm</span>/Support/TargetRegistry.h"<br>
#include "<span class="il">llvm</span>/Support/raw_ostream.h"<br>
+<br>
+#include "../Target/X86/MCTargetDesc/X86FixupKinds.h"<br>
+</div></blockquote></div><br><div>This is a pretty egregious layering violation. Please fix or revert, this causes all kinds of problems with improper dependencies between various components.</div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>