[llvm-commits] [llvm] r146688 - in /llvm/trunk: include/llvm/Transforms/Utils/ModuleUtils.h lib/Transforms/Instrumentation/AddressSanitizer.cpp lib/Transforms/Utils/ModuleUtils.cpp

Chandler Carruth chandlerc at google.com
Thu Dec 15 16:45:57 PST 2011


On Thu, Dec 15, 2011 at 4:25 PM, Kostya Serebryany <kcc at google.com> wrote:

> yea, agree.
> asan currently (almost) lacks this kind of testing and we will need to add
> more tests (not just this one).
>

I understand. It's useful for reviewers as well when fixing bugs to include
at least the test for that fix, as it helps document exactly what the end
result should be. Might be a good place to start fleshing out the test
suite.

For example, the current asan test suite has a test that invokes objdump
> and counts how many specific instructions are present in a given function.
> FileCheck-like test should be much simpler.
>

Yikes, yea. If the FileCheck tests are proving hard or onerous to write, we
can look for better was to construct them, etc., but I'm hopeful.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111215/d6cad990/attachment.html>


More information about the llvm-commits mailing list