[llvm-commits] [llvm] r145993 - /llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp

[Chandler Carruth]

On Tue, Dec 6, 2011 at 3:59 PM, Jakub Staszak <jstaszak at apple.com> wrote:

> Author: kuba
> Date: Tue Dec  6 17:59:33 2011
> New Revision: 145993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=145993&view=rev
> Log:
> - Remove unneeded #includes.
> - Remove unused types/fields.
> - Add some constantness.
>

Thanks for the cleanups! Any general comments on the code is also welcome.
=D


>   /// \brief Iterator over blocks within the chain.
> -  typedef SmallVectorImpl<MachineBasicBlock *>::iterator iterator;
> -  typedef SmallVectorImpl<MachineBasicBlock *>::reverse_iterator
> +  typedef SmallVectorImpl<MachineBasicBlock *>::const_iterator iterator;
> +  typedef SmallVectorImpl<MachineBasicBlock *>::const_reverse_iterator
>       reverse_iterator;
>

Is this one still needed? You deleted the rbegin/rend methods...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111206/d53fd1ca/attachment.html>