<div class="gmail_quote">On Tue, Dec 6, 2011 at 3:59 PM, Jakub Staszak <span dir="ltr"><<a href="mailto:jstaszak@apple.com">jstaszak@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Author: kuba<br>
Date: Tue Dec  6 17:59:33 2011<br>
New Revision: 145993<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=145993&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=145993&view=rev</a><br>
Log:<br>
- Remove unneeded #includes.<br>
- Remove unused types/fields.<br>
- Add some constantness.<br></blockquote><div><br></div><div>Thanks for the cleanups! Any general comments on the code is also welcome. =D</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

   /// \brief Iterator over blocks within the chain.<br>
-  typedef SmallVectorImpl<MachineBasicBlock *>::iterator iterator;<br>
-  typedef SmallVectorImpl<MachineBasicBlock *>::reverse_iterator<br>
+  typedef SmallVectorImpl<MachineBasicBlock *>::const_iterator iterator;<br>
+  typedef SmallVectorImpl<MachineBasicBlock *>::const_reverse_iterator<br>
       reverse_iterator;<br></blockquote><div><br></div><div>Is this one still needed? You deleted the rbegin/rend methods...</div></div>