[llvm-commits] AVX1 Code Generation - VSHUFP extension

[Bruno Cardoso Lopes]

Hi Elena,

> I fixed the code. The input mask remains unchanged now.
> Please take a look.

A couple more comments:
1) Please change the comments to use "//" instead of "/**/".
2) Your patch is broken: contains the diff of the same file more than once.
3) No need to have 2 isCommutedVSHUFP*. Just have one function and
check "ps" or "pd" using the number of elements using
VT.getVectorNumElements() - but make sure to still check for 256-bits.
4) Why don't match when V2IsUndef? I suppose it's because you want the
shuffle to be xformed to a "extract of the low part"+128_bit-shuffle
later. If that's the case, add a comment saying that!

Thanks

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc