[llvm-commits] [llvm] r142440 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

[Bill Wendling]

On Oct 18, 2011, at 4:12 PM, Jim Grosbach wrote:

> On Oct 18, 2011, at 3:52 PM, Bill Wendling <isanbard at gmail.com> wrote:
> 
>> +    if (NumLPads < 256) {
>> +      AddDefaultPred(BuildMI(DispatchBB, dl, TII->get(ARM::CMPri))
>> +                     .addReg(NewVReg1)
>> +                     .addImm(NumLPads));
>> +    } else {
>> +      unsigned VReg1 = MRI->createVirtualRegister(TRC);
>> +      AddDefaultPred(BuildMI(DispatchBB, dl, TII->get(ARM::MOVi16), VReg1)
>> +                     .addImm(NumLPads & 0xFF));
> 
> 0xffff right?
> 
doh!

>> +      unsigned VReg2 = MRI->createVirtualRegister(TRC);
>> +      AddDefaultPred(BuildMI(DispatchBB, dl, TII->get(ARM::MOVTi16), VReg2)
>> +                     .addReg(VReg1)
>> +                     .addImm(NumLPads >> 16));
> 
> We don't need the second instruction if it's between 256 and 64k(?)

Okay. Done.

-bw