[llvm-commits] [llvm] r141231 - in /llvm/trunk/lib/TableGen: TGLexer.cpp TGLexer.h

[David A. Greene]

James Molloy <James.Molloy at arm.com> writes:

> Hi David,
>
> --- llvm/trunk/lib/TableGen/TGLexer.cpp (original)
> +++ llvm/trunk/lib/TableGen/TGLexer.cpp Wed Oct  5 17:42:35 2011
> @@ -228,6 +228,7 @@
>
>    if (Len == 5 && !memcmp(IdentStart, "class", 5)) return tgtok::Class;
>    if (Len == 3 && !memcmp(IdentStart, "def", 3)) return tgtok::Def;
> +  if (Len == 8 && !memcmp(IdentStart, "multidef", 3)) return tgtok::MultiDef;
>    if (Len == 4 && !memcmp(IdentStart, "defm", 4)) return tgtok::Defm;
>    if (Len == 10 && !memcmp(IdentStart, "multiclass", 10))
>      return tgtok::MultiClass;
>
> That doesn't look right, it looks like a copy-paste error. Would '8' not make more sense in the third parameter to memcmp?

Yep.  Will fix.

Thanks!

                              -Dave