[llvm-commits] [llvm] r141231 - in /llvm/trunk/lib/TableGen: TGLexer.cpp TGLexer.h

James Molloy James.Molloy at arm.com
Thu Oct 6 00:04:04 PDT 2011


Hi David,

--- llvm/trunk/lib/TableGen/TGLexer.cpp (original)
+++ llvm/trunk/lib/TableGen/TGLexer.cpp Wed Oct  5 17:42:35 2011
@@ -228,6 +228,7 @@

   if (Len == 5 && !memcmp(IdentStart, "class", 5)) return tgtok::Class;
   if (Len == 3 && !memcmp(IdentStart, "def", 3)) return tgtok::Def;
+  if (Len == 8 && !memcmp(IdentStart, "multidef", 3)) return tgtok::MultiDef;
   if (Len == 4 && !memcmp(IdentStart, "defm", 4)) return tgtok::Defm;
   if (Len == 10 && !memcmp(IdentStart, "multiclass", 10))
     return tgtok::MultiClass;

That doesn't look right, it looks like a copy-paste error. Would '8' not make more sense in the third parameter to memcmp?

Cheers,

James

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of David Greene
Sent: 05 October 2011 23:43
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] [llvm] r141231 - in /llvm/trunk/lib/TableGen: TGLexer.cpp TGLexer.h

Author: greened
Date: Wed Oct  5 17:42:35 2011
New Revision: 141231

URL: http://llvm.org/viewvc/llvm-project?rev=141231&view=rev
Log:
Lexer Support for Multidefs

Add keyword support for multidefs.

Modified:
    llvm/trunk/lib/TableGen/TGLexer.cpp
    llvm/trunk/lib/TableGen/TGLexer.h

Modified: llvm/trunk/lib/TableGen/TGLexer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGLexer.cpp?rev=141231&r1=141230&r2=141231&view=diff
==============================================================================
--- llvm/trunk/lib/TableGen/TGLexer.cpp (original)
+++ llvm/trunk/lib/TableGen/TGLexer.cpp Wed Oct  5 17:42:35 2011
@@ -228,6 +228,7 @@

   if (Len == 5 && !memcmp(IdentStart, "class", 5)) return tgtok::Class;
   if (Len == 3 && !memcmp(IdentStart, "def", 3)) return tgtok::Def;
+  if (Len == 8 && !memcmp(IdentStart, "multidef", 3)) return tgtok::MultiDef;
   if (Len == 4 && !memcmp(IdentStart, "defm", 4)) return tgtok::Defm;
   if (Len == 10 && !memcmp(IdentStart, "multiclass", 10))
     return tgtok::MultiClass;

Modified: llvm/trunk/lib/TableGen/TGLexer.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGLexer.h?rev=141231&r1=141230&r2=141231&view=diff
==============================================================================
--- llvm/trunk/lib/TableGen/TGLexer.h (original)
+++ llvm/trunk/lib/TableGen/TGLexer.h Wed Oct  5 17:42:35 2011
@@ -41,7 +41,7 @@
     equal, question,    // = ?

     // Keywords.
-    Bit, Bits, Class, Code, Dag, Def, Defm, Field, In, Int, Let, List,
+    Bit, Bits, Class, Code, Dag, Def, MultiDef, Defm, Field, In, Int, Let, List,
     MultiClass, String,

     // !keywords.


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.





More information about the llvm-commits mailing list