[llvm-commits] [llvm] r139828 - in /llvm/trunk: lib/Target/ARM/ARMInstrThumb2.td test/MC/ARM/basic-thumb2-instructions.s

[Jim Grosbach]

Quite right. Fixed, along with some other tidying up, in r139849. Thanks!
-jim
On Sep 15, 2011, at 2:10 PM, Bill Wendling wrote:

> On Sep 15, 2011, at 12:46 PM, Jim Grosbach wrote:
> 
>> Author: grosbach
>> Date: Thu Sep 15 14:46:13 2011
>> New Revision: 139828
>> 
>> Modified: llvm/trunk/test/MC/ARM/basic-thumb2-instructions.s
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/basic-thumb2-instructions.s?rev=139828&r1=139827&r2=139828&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/MC/ARM/basic-thumb2-instructions.s (original)
>> +++ llvm/trunk/test/MC/ARM/basic-thumb2-instructions.s Thu Sep 15 14:46:13 2011
>> @@ -1442,6 +1442,38 @@
>> 
>> 
>> @------------------------------------------------------------------------------
>> +@ REV16
>> + at ------------------------------------------------------------------------------
>> +        rev16.w r1, r2
>> +        rev16 r2, r8
>> +        itt ne
>> +        rev16ne r1, r2
>> +        rev16ne r1, r8
>> +
>> +	rev16.w	r1, r2                  @ encoding: [0x92,0xfa,0x92,0xf1]
>> +	rev16.w	r2, r8                  @ encoding: [0x98,0xfa,0x98,0xf2]
>> +	itt	ne                      @ encoding: [0x1c,0xbf]
>> +	rev16ne	r1, r2                  @ encoding: [0x51,0xba]
>> +	rev16ne.w	r1, r8          @ encoding: [0x98,0xfa,0x98,0xf1]
>> +
> 
> These seem to be missing the "@ CHECK" prefix.
> 
>> +
>> + at ------------------------------------------------------------------------------
>> +@ REVSH
>> + at ------------------------------------------------------------------------------
>> +        revsh.w r1, r2
>> +        revsh r2, r8
>> +        itt ne
>> +        revshne r1, r2
>> +        revshne r1, r8
>> +
>> +	revsh.w	r1, r2                  @ encoding: [0x92,0xfa,0xb2,0xf1]
>> +	revsh.w	r2, r8                  @ encoding: [0x98,0xfa,0xb8,0xf2]
>> +	itt	ne                      @ encoding: [0x1c,0xbf]
>> +	revshne	r1, r2                  @ encoding: [0xd1,0xba]
>> +	revshne.w	r1, r8          @ encoding: [0x98,0xfa,0xb8,0xf1]
>> +
> ditto...
> 
> -bw
>