[llvm-commits] [llvm] r139680 - in /llvm/trunk: lib/DebugInfo/CMakeLists.txt lib/DebugInfo/DWARFContext.cpp lib/DebugInfo/DWARFContext.h lib/DebugInfo/DWARFDebugArangeSet.cpp lib/DebugInfo/DWARFDebugArangeSet.h lib/DebugInfo/DWARFDebugAranges.cpp

[Benjamin Kramer]

On Wed, Sep 14, 2011 at 11:22, Evan Cheng <evan.cheng at apple.com> wrote:
>
> On Sep 13, 2011, at 6:09 PM, Benjamin Kramer wrote:
>
>> +
>> +class DWARFDebugArangeSet {
>> +public:
>> +  struct Header {
>> +    // The total length of the entries for that set, not including the length
>> +    // field itself.
>> +    uint32_t Length;
>> +    // The DWARF version number.
>> +    uint16_t Version;
>> +    // The offset from the beginning of the .debug_info section of the
>> +    // compilation unit entry referenced by the table.
>> +    uint32_t CuOffset;
>> +    // The size in bytes of an address on the target architecture. For segmented
>> +    // addressing, this is the size of the offset portion of the address.
>> +    uint8_t AddrSize;
>> +    // The size in bytes of a segment descriptor on the target architecture.
>> +    // If the target system uses a flat address space, this value is 0.
>> +    uint8_t SegSize;
>> +  };
>
> Can you pack this class better to save some space?
>
> Evan

I moved the version field in r139712. There aren't many instances of
this data structure around usually (about 1000 in clang.dSYM, which is
HUGE), so packing it further isn't worth it.

- Ben