[llvm-commits] [PATCH] Clean up RegOp2MemOp tables in X86InstrInfo.cpp

[David Meyer]

Hi Jakob,

I added a brief comment to each. New patch attached.

Thanks,
 - pdox

On Tue, Sep 6, 2011 at 10:06 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>
> On Sep 5, 2011, at 9:40 PM, David Meyer wrote:
>
>> Hello!
>>
>> This patch:
>>
>> * Combines Alignment, AuxInfo, and TB_NOT_REVERSABLE flag into a
>> single field (Flags), which is a bitwise OR of items from the TB_*
>> enum. This makes it easier to add new information in the future.
>>
>> * Gives every static array an equivalent layout: { RegOp, MemOp, Flags }
>>
>> * Adds a helper function, AddTableEntry, to avoid duplication of the
>> insertion code.
>>
>> * Renames TB_NOT_REVERSABLE to TB_NO_REVERSE.
>>
>> * Adds TB_NO_FORWARD, which is analogous to TB_NO_REVERSE, except that
>> it prevents addition of the Reg->Mem entry. (This is going to be used
>> by Native Client, in the next CL).
>
> Looks good, but please add an explanation of the TB_INDEX* and TB_ALIGN* enums.
>
> /jakob
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reg2mem.v2.patch
Type: text/x-patch
Size: 69540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110906/897df316/attachment.bin>