[llvm-commits] [PATCH] Clean up RegOp2MemOp tables in X86InstrInfo.cpp

[Jakob Stoklund Olesen]

On Sep 5, 2011, at 9:40 PM, David Meyer wrote:

> Hello!
> 
> This patch:
> 
> * Combines Alignment, AuxInfo, and TB_NOT_REVERSABLE flag into a
> single field (Flags), which is a bitwise OR of items from the TB_*
> enum. This makes it easier to add new information in the future.
> 
> * Gives every static array an equivalent layout: { RegOp, MemOp, Flags }
> 
> * Adds a helper function, AddTableEntry, to avoid duplication of the
> insertion code.
> 
> * Renames TB_NOT_REVERSABLE to TB_NO_REVERSE.
> 
> * Adds TB_NO_FORWARD, which is analogous to TB_NO_REVERSE, except that
> it prevents addition of the Reg->Mem entry. (This is going to be used
> by Native Client, in the next CL).

Looks good, but please add an explanation of the TB_INDEX* and TB_ALIGN* enums.

/jakob