[llvm-commits] [llvm] r138625 - /llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp

[Chandler Carruth]

On Thu, Aug 25, 2011 at 11:19 PM, Owen Anderson <resistor at mac.com> wrote:

> Author: resistor
> Date: Fri Aug 26 01:19:51 2011
> New Revision: 138625
>
> URL: http://llvm.org/viewvc/llvm-project?rev=138625&view=rev
> Log:
> Fix PR10755 by checking for invalid predicate codes from UNPREDICTABLE t2IT
> instructions when decoding their successors.
> This is the last disassembly crash detected by exhaustive Thumb2
> instruction space.  Major thanks to Chandler Carruth for making this kind of
> exhaustive testing possible.
>

Dare I say it... test case?

:: ducks ::


>
> Modified:
>    llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
>
> Modified: llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp?rev=138625&r1=138624&r2=138625&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp Fri Aug 26
> 01:19:51 2011
> @@ -376,6 +376,8 @@
>   unsigned CC;
>   if (!ITBlock.empty()) {
>     CC = ITBlock.back();
> +    if (CC == 0xF)
> +      CC = ARMCC::AL;
>     ITBlock.pop_back();
>   } else
>     CC = ARMCC::AL;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110825/f4bc0829/attachment.html>