<div class="gmail_quote">On Thu, Aug 25, 2011 at 11:19 PM, Owen Anderson <span dir="ltr"><<a href="mailto:resistor@mac.com">resistor@mac.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Author: resistor<br>
Date: Fri Aug 26 01:19:51 2011<br>
New Revision: 138625<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=138625&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=138625&view=rev</a><br>
Log:<br>
Fix PR10755 by checking for invalid predicate codes from UNPREDICTABLE t2IT instructions when decoding their successors.<br>
This is the last disassembly crash detected by exhaustive Thumb2 instruction space.  Major thanks to Chandler Carruth for making this kind of exhaustive testing possible.<br></blockquote><div><br></div><div>Dare I say it... test case?</div>
<div><br></div><div>:: ducks ::</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Modified:<br>
    llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp?rev=138625&r1=138624&r2=138625&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp?rev=138625&r1=138624&r2=138625&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp (original)<br>
+++ llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassembler.cpp Fri Aug 26 01:19:51 2011<br>
@@ -376,6 +376,8 @@<br>
   unsigned CC;<br>
   if (!ITBlock.empty()) {<br>
     CC = ITBlock.back();<br>
+    if (CC == 0xF)<br>
+      CC = ARMCC::AL;<br>
     ITBlock.pop_back();<br>
   } else<br>
     CC = ARMCC::AL;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>