[llvm-commits] [llvm] r135760 - in /llvm/trunk: cmake/modules/LLVMLibDeps.cmake lib/Support/CMakeLists.txt lib/Support/TargetRegistry.cpp lib/Target/CMakeLists.txt lib/Target/TargetRegistry.cpp

Chandler Carruth chandlerc at gmail.com
Tue Aug 23 11:15:49 PDT 2011


On Sun, Aug 14, 2011 at 12:06 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> On Sat, Aug 6, 2011 at 3:28 AM, Chandler Carruth <chandlerc at gmail.com>wrote:
>
>> On Fri, Aug 5, 2011 at 10:40 PM, Chandler Carruth <chandlerc at gmail.com>wrote:
>>
>>> On Mon, Aug 1, 2011 at 3:40 PM, Evan Cheng <evan.cheng at apple.com> wrote:
>>>
>>>> I am not comfortable with a few weeks. Is it not possible to just move
>>>> TargetRegistry.cpp back to Support?
>>>
>>>
>>> Putting this into Support violates a lot of layering principles. I care a
>>> lot about layering and other invariants, thats how we keep building and
>>> using LLVM effectively.
>>>
>>> Anyways, I understand the need for an expedient solution. I think I have
>>> a reasonable compromise -- we could move the registry into MC. The only
>>> targets that don't actually need MC are the CBackend and the CppBackend.
>>> That seems likely to be the ongoing trend. It would allow MC clients to not
>>> pull in any part of Target.
>>>
>>> Best of all, that's where the other two pieces of the registry already
>>> live: the Reloc and CodeModel classes.
>>>
>>> I'm trying this out now to ensure it actually works, and does in fact
>>> shrink llvm-mc back down to size.
>>>
>>
>> I've attached the patch. It looks like it will work. The disassembler (as
>> well as many other libraries) no longer depends on Target from my testing.
>> This look OK to commit?
>>
>> I was thinking if it cleans up stuff we could rename this the
>> 'MachineRegistry'... but not sure it really matters.
>>
>
> Ping. Adding Eric as he indicated on IRC a week ago he might be able to
> review this, but i've not heard anything...
>

Ping?? ;] I could swear I remember Evan saying this should be fixed
quickly.... =D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110823/e825350f/attachment.html>


More information about the llvm-commits mailing list