[llvm-commits] [PATCH] Add Pattern ID Information

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Thu Aug 4 14:12:26 PDT 2011


> It doesn't bloat.  It reduces.

Regarding tablegen files, If it doesn't make the code really hard to
read and understand (as in using black magic lisp-like tablegen
constructs) I don't have objections at all. But regarding x86 specific
lowering code, I think is a bad ideia to write code trying to support
wider than 256-bit for now, for that I think we should wait the next
wider ISA to come.

> And it's not a forecast.  This stuff is well-known already.  It's here
> today.  Look at how similar AVX is to SSE and how similar SSE is to MMX.
> There's tons of redundancy in the existing specification.  It's
> non-orthogonal and cumbersome to maintain.

x86 is pretty weird, I wouldn't rely 100% on it.

> Honestly, we really don't want to prepare for the future and make things
> simpler for the average developer in the process?  Especially after the
> discussion about a year or so ago where people seemed at least
> interested in the idea?
>
> At least allow me to present the work without facing a crowd that's
> already made up its mind.

Of course. Go for it :)

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc




More information about the llvm-commits mailing list