[llvm-commits] [PATCH 02/20] [AVX] Remove Mutating Members from Inits

David A. Greene greened at obbligato.org
Wed Jul 20 13:36:01 PDT 2011


dag at cray.com (David A. Greene) writes:

>> You have a lot of explicit ArrayRef constructor calls. That shouldn't be necessary. You should be getting implicit conversions.
>
> I'll check that out.  Certainly I won't get implicit conversions for
> iterator pairs.  :)
>
>> And please use the new makeArrayRef when that doesn't work.
>>
>>     +    Init *NewBits[1] = { VI };
>>
>> This should not be necessary, ArrayRef has a single-element constructor.
>
> Urk.  Missed that one.  Thanks for the pointer.

Both done.  Thanks!

                             -Dave



More information about the llvm-commits mailing list