[llvm-commits] [PATCH 02/20] [AVX] Remove Mutating Members from Inits

[David A. Greene]

Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> On Jul 19, 2011, at 1:11 PM, David Greene wrote:
>
>     Delete all member functions that modify Init state.  This is in
>     preparation for making Inits const everywhere and finally, converting
>     them to FoldingSetNodes.
>
> Thanks, David.
>
> You have a lot of explicit ArrayRef constructor calls. That shouldn't be necessary. You should be getting implicit conversions.

I'll check that out.  Certainly I won't get implicit conversions for
iterator pairs.  :)

> And please use the new makeArrayRef when that doesn't work.
>
>     +    Init *NewBits[1] = { VI };
>
> This should not be necessary, ArrayRef has a single-element constructor.

Urk.  Missed that one.  Thanks for the pointer.

                              -Dave