[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[Jakob Stoklund Olesen]

On Jul 12, 2011, at 3:37 PM, David A. Greene wrote:

> Evan Cheng <evan.cheng at apple.com> writes:
> 
>> This doesn't work. People are very busy, reviewing patches is but a small part of everyone's daily work.
>> 
>> If you keep the patches small and incremental, then it's perfectly ok
>> to commit and have the patches reviewed post commit. But that's not
>> what's happening here.
> 
> What's the definition of "small?"  I am splitting this out into multiple
> patches but some (like constifying Inits) are still rather large.
> Logically, they are very simple patches but they touch a lot of code.

A large patch with only mechanical changes is not a problem as long as it doesn't contain any other changes.

When in doubt, split it.

/jakob