[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[David A. Greene]

Evan Cheng <evan.cheng at apple.com> writes:

> This doesn't work. People are very busy, reviewing patches is but a small part of everyone's daily work.
>
> If you keep the patches small and incremental, then it's perfectly ok
> to commit and have the patches reviewed post commit. But that's not
> what's happening here.

What's the definition of "small?"  I am splitting this out into multiple
patches but some (like constifying Inits) are still rather large.
Logically, they are very simple patches but they touch a lot of code.

                           -Dave