[llvm-commits] PATCH: FileCheck-ize a pile of tests under CodeGen/X86

[Chandler Carruth]

The only remaining patches I've found I need for the tests we're running are
attached.

The ARM patch is a normal FileCheck-izing patch.

The Linker test patch just uses a simpler syntax for the {} quoting. I feel
like there has to be a better / more modern way to write llvm-link tests
than 'echo {<my-IR-here>} | llvm-as ...', feel free to tell me what the
desired cleanups are here!

Thanks again!
-Chandler

On Sat, Jul 2, 2011 at 2:17 AM, Chandler Carruth <chandlerc at google.com>wrote:

> Hello,
>
> I'm stuck with a (bad) emulator of Lit to run LLVM tests, and one of its
> challenges is handling strang TCL quoting rules. A bunch of tests didn't
> work with this system, but I figured I could just pro-actively convert them
> to FileCheck as that's the desired direction anyways. I've attached all the
> CodeGen/X86 patches to this email. I'll have some patches to other tests as
> well coming up.
>
> Where I understand essentially what the test is after, I've tried to clean
> up and tighten up the test as best I can using the newer facilities of
> FileCheck. Where I don't understand the test's intent, I stay as close as I
> can to the original grep-based checks.
>
> I've tried to consistently provide function boundaries for the CHECKs so
> that some of these tiny test files could be merged. If folks have specific
> merges they'd like me to perform while I'm here, I'll do so.
>
> I've also tried to consistently relax the register names checked where I
> had some clue that it would be safe. Please let me know if I've gone too far
> anywhere or not done enough anywhere.
>
> Finally, any requests, suggestions, or comments about how I'm converting
> them are very welcome. Let me know if I should just commit the remainder
> directly or keep mailing for review!
>
> Thanks!
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/50674475/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: filecheck_arm.patch
Type: text/x-patch
Size: 576 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/50674475/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linker_quoting.patch
Type: text/x-patch
Size: 1170 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/50674475/attachment-0001.bin>