[llvm-commits] PATCH: FileCheck-ize a pile of tests under CodeGen/X86

Sat Jul 2 02:17:33 PDT 2011

Hello,

I'm stuck with a (bad) emulator of Lit to run LLVM tests, and one of its
challenges is handling strang TCL quoting rules. A bunch of tests didn't
work with this system, but I figured I could just pro-actively convert them
to FileCheck as that's the desired direction anyways. I've attached all the
CodeGen/X86 patches to this email. I'll have some patches to other tests as
well coming up.

Where I understand essentially what the test is after, I've tried to clean
up and tighten up the test as best I can using the newer facilities of
FileCheck. Where I don't understand the test's intent, I stay as close as I
can to the original grep-based checks.

I've tried to consistently provide function boundaries for the CHECKs so
that some of these tiny test files could be merged. If folks have specific
merges they'd like me to perform while I'm here, I'll do so.

I've also tried to consistently relax the register names checked where I had
some clue that it would be safe. Please let me know if I've gone too far
anywhere or not done enough anywhere.

Finally, any requests, suggestions, or comments about how I'm converting
them are very welcome. Let me know if I should just commit the remainder
directly or keep mailing for review!

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FileCheck-ize-a-test-no-functionality-changed.patch
Type: text/x-patch
Size: 752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-FileCheck-ize-another-test.-This-one-is-more-clear-a.patch
Type: text/x-patch
Size: 2334 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-FileCheck-ize-another-test-making-it-much-more-preci.patch
Type: text/x-patch
Size: 1836 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-FileCheck-ize-another-codegen-test-tightening-it-up.patch
Type: text/x-patch
Size: 2520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-FileCheck-ize-another-test-and-upgrade-its-syntax-a-.patch
Type: text/x-patch
Size: 1242 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Partially-FileCheck-ize-a-test-to-remove-a-weird-quo.patch
Type: text/x-patch
Size: 1387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-FileCheck-ize-another-codegen-test.patch
Type: text/x-patch
Size: 1029 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-FileCheck-ize.patch
Type: text/x-patch
Size: 929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-FileCheck-ize-and-simplify-this-test.patch
Type: text/x-patch
Size: 1113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-FileCheck-ize-a-test-avoiding-a-temporary-file.patch
Type: text/x-patch
Size: 1211 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-FileCheck-ize.patch
Type: text/x-patch
Size: 1251 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-FileCheck-ize.patch
Type: text/x-patch
Size: 780 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-FileCheck-ize-tightening-checks-and-avoiding-a-tempo.patch
Type: text/x-patch
Size: 1092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-FileCheck-ize-tightening-checks-and-avoiding-a-tempo.patch
Type: text/x-patch
Size: 1098 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-FileCheck-ize-and-modernize-the-RUN-line.patch
Type: text/x-patch
Size: 1299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-FileCheck-ize-and-simplify-RUNs.patch
Type: text/x-patch
Size: 1280 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-FileCheck-ize-and-modernize-IR.patch
Type: text/x-patch
Size: 1687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018-FileCheck-ize.patch
Type: text/x-patch
Size: 1105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019-Remove-a-grep-that-is-already-checked-with-FileCheck.patch
Type: text/x-patch
Size: 840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020-FileCheck-ize.patch
Type: text/x-patch
Size: 1106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0021-FileCheck-ize-and-cleanup-IR.patch
Type: text/x-patch
Size: 1094 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0022-FileCheck-ize-and-tighten-up-assertions-to-only-chec.patch
Type: text/x-patch
Size: 1386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0023-FileCheck-ize.patch
Type: text/x-patch
Size: 1041 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110702/8a2645a1/attachment-0022.bin>