[llvm-commits] [llvm] r133669 - /llvm/trunk/include/llvm/Target/TargetAsmInfo.h

[Bill Wendling]

On Jun 22, 2011, at 9:39 PM, Chris Lattner wrote:

> On Jun 22, 2011, at 5:12 PM, Bill Wendling wrote:
> 
>> Author: void
>> Date: Wed Jun 22 19:12:58 2011
>> New Revision: 133669
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=133669&view=rev
>> Log:
>> Allow the AsmInfo to query the TLOF to see if it supports compact unwind.
> 
> Hi Bill,
> 
> Why have this *and* getCompactUnwindSection?  Can't getCompactUnwindSection just return null if there is no support?

I was thinking of that. I can't think of a reason to have both of them, so I'll opt for returning the MCSection pointer one. If it turns out that we need a predicate, it'll be easy to add later. :-)

> If we need the predicate, it would be better to name this just "supportsCompactUnwindInfo() or better yet "hasCompactUnwindInfoSupport()"

-bw