[llvm-commits] [llvm] r133669 - /llvm/trunk/include/llvm/Target/TargetAsmInfo.h

[Chris Lattner]

On Jun 22, 2011, at 5:12 PM, Bill Wendling wrote:

> Author: void
> Date: Wed Jun 22 19:12:58 2011
> New Revision: 133669
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=133669&view=rev
> Log:
> Allow the AsmInfo to query the TLOF to see if it supports compact unwind.

Hi Bill,

Why have this *and* getCompactUnwindSection?  Can't getCompactUnwindSection just return null if there is no support?  If we need the predicate, it would be better to name this just "supportsCompactUnwindInfo() or better yet "hasCompactUnwindInfoSupport()"

-Chris

> 
> Modified:
>    llvm/trunk/include/llvm/Target/TargetAsmInfo.h
> 
> Modified: llvm/trunk/include/llvm/Target/TargetAsmInfo.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetAsmInfo.h?rev=133669&r1=133668&r2=133669&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Target/TargetAsmInfo.h (original)
> +++ llvm/trunk/include/llvm/Target/TargetAsmInfo.h Wed Jun 22 19:12:58 2011
> @@ -79,6 +79,10 @@
>     return TLOF->isFunctionEHFrameSymbolPrivate();
>   }
> 
> +  bool getSupportsCompactUnwindInfo() const {
> +    return TLOF->getSupportsCompactUnwindInfo();
> +  }
> +
>   const unsigned *getCalleeSavedRegs(MachineFunction *MF = 0) const {
>     return TRI->getCalleeSavedRegs(MF);
>   }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits