[llvm-commits] [llvm] r132882 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/Target/X86/X86InstrInfo.cpp test/CodeGen/Thumb2/machine-licm.ll

Rafael Avila de Espindola rafael.espindola at gmail.com
Tue Jun 14 11:20:08 PDT 2011


>> -----------
>> ...
>> jne foo
>> jmp bar
>>
>> foo:
>> ----------
>
> Hi Rafael,
>
> What was the bug? isBlockOnlyReachableByFallthrough previously checked
> isBarrier() on the last instruction of the block, which should handle this case.
> Why didn't that work?

You are right. The case that would fail would be a redundant conditional 
jump to the next block. I couldn't find such a case anymore while 
building clang in debug mode, so I reverted this part of the patch.

Sorry for the noise.

> Dan
>

Cheers,
Rafael



More information about the llvm-commits mailing list