[llvm-commits] [llvm] r132882 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/Target/X86/X86InstrInfo.cpp test/CodeGen/Thumb2/machine-licm.ll

[Dan Gohman]

On Jun 11, 2011, at 8:20 PM, Rafael Espindola wrote:

> Author: rafael
> Date: Sat Jun 11 22:20:32 2011
> New Revision: 132882
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=132882&view=rev
> Log:
> AnalyzeBranch doesn't change which successors a bb has, just the order
> we try to branch to them.
> 
> Before we were creating successor lists with duplicated entries. Fixing that
> found a bug in isBlockOnlyReachableByFallthrough that would causes it to
> return the wrong answer for
> 
> -----------
> ...
> jne foo
> jmp bar
> 
> foo:
> ----------

Hi Rafael,

What was the bug? isBlockOnlyReachableByFallthrough previously checked
isBarrier() on the last instruction of the block, which should handle this case.
Why didn't that work?

Dan