[llvm-commits] [llvm] r131705 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Jakob Stoklund Olesen]

On May 19, 2011, at 7:38 PM, Cameron Zwarich wrote:

> On May 19, 2011, at 5:46 PM, Jakob Stoklund Olesen wrote:
> 
>> On May 19, 2011, at 4:44 PM, Cameron Zwarich wrote:
>> 
>>> Author: zwarich
>>> Date: Thu May 19 18:44:34 2011
>>> New Revision: 131705
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=131705&view=rev
>>> Log:
>>> Fix PR9955 by only attaching load memory operands to load instructions and
>>> similarly for stores. Now "make check" passes with the MachineVerifier forced
>>> on with the VerifyCoalescing option!
>> 
>> Woot!
>> 
>> Do you know how slow the verifier is compared to, say, register coalescing? It may be worthwhile to run at least one pass in +Asserts builds.
> 
> I haven't run any timings, partially since it doesn't run as a separate pass with VerifyCoalescing (we should probably change that). It's not yet ready to be turned on in +Asserts builds, since it has some failures on test-suite. Once it passes test-suite on x86 and ARM and survives a self-host, we should consider turning it on for +Asserts builds.

We could run one pass before the register allocator passes. That could verify SSA form, and it would catch most cases of bad code coming from isel and target lowering hooks.

The -verify-coalescing passes are useful for catching LiveIntervals bugs, but I don't know if they need to be on permanently.

> We should also turn it on for all "make check" tests somehow.

That would be automatic since most developers build +Asserts.