[llvm-commits] [llvm] r128952 - /llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h

[Chandler Carruth]

On Tue, Apr 5, 2011 at 4:29 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Apr 5, 2011, at 4:03 PM, Chandler Carruth wrote:
>
> > Author: chandlerc
> > Date: Tue Apr  5 18:03:24 2011
> > New Revision: 128952
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=128952&view=rev
> > Log:
> > Provide an empty virtual destructor to go with the virtual methods in
> > this class. Clang was warning on this with -Wnon-virtual-dtor.
>
> Hi Chandler,
>
> Please move the method out of line, since it is the only candidate for
> being a key function.  Thanks!
>

Done in r128964. Wonder if there is a feasible way to implement a warning
for *this*...


>
> -Chris
>
> >
> > Modified:
> >    llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h
> >
> > Modified: llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h?rev=128952&r1=128951&r2=128952&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h (original)
> > +++ llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h Tue Apr  5
> 18:03:24 2011
> > @@ -33,6 +33,7 @@
> >   void operator=(const RTDyldMemoryManager&);       // DO NOT IMPLEMENT
> > public:
> >   RTDyldMemoryManager() {}
> > +  virtual ~RTDyldMemoryManager() {}
> >
> >   // Allocate ActualSize bytes, or more, for the named function. Return
> >   // a pointer to the allocated memory and update Size to reflect how
> much
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110405/ed9b686d/attachment.html>