<div class="gmail_quote">On Tue, Apr 5, 2011 at 4:29 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com">clattner@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On Apr 5, 2011, at 4:03 PM, Chandler Carruth wrote:<br>
<br>
> Author: chandlerc<br>
> Date: Tue Apr  5 18:03:24 2011<br>
> New Revision: 128952<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=128952&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=128952&view=rev</a><br>
> Log:<br>
> Provide an empty virtual destructor to go with the virtual methods in<br>
> this class. Clang was warning on this with -Wnon-virtual-dtor.<br>
<br>
</div>Hi Chandler,<br>
<br>
Please move the method out of line, since it is the only candidate for being a key function.  Thanks!<br></blockquote><div><br></div><div>Done in r128964. Wonder if there is a feasible way to implement a warning for *this*...</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888"><br>
-Chris<br>
</font><div><div></div><div class="h5"><br>
><br>
> Modified:<br>
>    llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h<br>
><br>
> Modified: llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h?rev=128952&r1=128951&r2=128952&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h?rev=128952&r1=128951&r2=128952&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h (original)<br>
> +++ llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h Tue Apr  5 18:03:24 2011<br>
> @@ -33,6 +33,7 @@<br>
>   void operator=(const RTDyldMemoryManager&);       // DO NOT IMPLEMENT<br>
> public:<br>
>   RTDyldMemoryManager() {}<br>
> +  virtual ~RTDyldMemoryManager() {}<br>
><br>
>   // Allocate ActualSize bytes, or more, for the named function. Return<br>
>   // a pointer to the allocated memory and update Size to reflect how much<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br>