[llvm-commits] [Review request][PATCH] MC: Recognize alignment stuff on PECOFF.

NAKAMURA Takumi geek4civic at gmail.com
Thu Mar 31 19:03:43 PDT 2011


Rafael, I am sorry to respond so late.

2011/3/28 Rafael Ávila de Espíndola <rafael.espindola at gmail.com>:
> Looks reasonable, but without updating the parser and adding a test it
> is hard to be sure.

I had not been unaware of MC parser. My 1st mission was to satisfy mingw32-as.
It makes sense, I will tweak MC later.
Excuse me, I have been testing release_29, to sped so much time :)

> Also, it might be better to add an empty implementation to MCStreamer
> instead of making it pure virtual. IMHO we have many pure virtuals in
> MCStreamer that could reasonably have an empty implementation.

Agree, though, I would clean up them later because I would like to
tweak .lcomm in 1st step.
Shall we clean up pure virtuals at first, do you think?

...Takumi




More information about the llvm-commits mailing list