[llvm-commits] [Review request][PATCH] MC: Recognize alignment stuff on PECOFF.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon Mar 28 06:54:13 PDT 2011


> I have not written comments in sources, though, I would like you all
> to review my patch to confirm whether I would take the *right* way or
> not, please.

Looks reasonable, but without updating the parser and adding a test it 
is hard to be sure.

Also, it might be better to add an empty implementation to MCStreamer 
instead of making it pure virtual. IMHO we have many pure virtuals in 
MCStreamer that could reasonably have an empty implementation.

> Checked on msvc10, cygwin-1.7, msysgit and mingw-w64-20101129.
>
> ...Takumi
>
>

Cheers,
Rafael



More information about the llvm-commits mailing list