[llvm-commits] [patch][lto] Use MC to scan for symbol definitions and uses

[Daniel Dunbar]

Very nice!

Patch looks quite reasonable to me, my only concern would be whether
it should wait for after 2.9 branch. It's probably safe, but it might
be better to take it afterwards in case it needs to bake.

Are you aware of situations the current code handles that this one doesn't?

 - Daniel

2011/2/26 Rafael Ávila de Espíndola <rafael.espindola at gmail.com>:
> The attached patch changes LTO to use MC for scanning symbol definitions
> and uses. It is not as complete as it could be, but it already handles
> some interesting cases:
>
> * A single .globl produces an undefined reference
> * Uses with no definitions produce undefined references
> * Definitions are correctly tracked as being local or global
> * Macro expansions are handled correctly :-)
>
> The patch also changes LLVM's handling of module level asm to make sure
> it always ends in a new line. This makes it easy to just pass that
> string to MC and match what we would see if printing to a file.
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>