[llvm-commits] [PATCH 1/4][llvm] Introduce Triple::MinGW.

[Ruben Van Boxem]

Better would be mingw*, and every toolchain should be classified as mingw32,
irrelevant if there's mingw.org or mingw-w64. (the 32 comes from the win32
API). mingw64 does not exist...
Op 15 feb. 2011 11:01 schreef "Duncan Sands" <baldrick at free.fr> het
volgende:
> Hi,
>
>> @@ -84,8 +84,10 @@ public:
>> FreeBSD,
>> Linux,
>> Lv2, // PS3
>> - MinGW32,
>> + MinGW, // i*86-pc-mingw32, *-w64-mingw32
>> +#define MinGW32 MinGW
>> MinGW64,
>> + // FIXME: They will be removed soon.
>
> why not remove them at once?
>
>> @@ -316,10 +316,8 @@ Triple::OSType Triple::ParseOS(StringRef OSName) {
>> return Linux;
>> else if (OSName.startswith("lv2"))
>> return Lv2;
>> - else if (OSName.startswith("mingw32"))
>> - return MinGW32;
>> - else if (OSName.startswith("mingw64"))
>> - return MinGW64;
>> + else if (OSName.startswith("mingw"))
>> + return MinGW;
>
> here you will accept mingw, ming32 and mingw64 while gcc only accepts
> mingw32. I'm not saying that this is wrong, but maybe it is unwise.
>
> Ciao, Duncan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110215/042189ab/attachment.html>