[llvm-commits] [Review request][Win64] Patches for Mingw-w64(and mingw64-clang)

[NAKAMURA Takumi]

2011/2/1 Óscar Fuentes <ofv at wanadoo.es>:
> You still have:
>
> +/* Define to 1 if you have the declaration of `strerror_s', and to 0 if
> +   don't. */
> +#cmakedefine HAVE_DECL_STRERROR_S ${HAVE_DECL_STRERROR_S}
>
> instead of
>
> +/* Define to 1 if you have the declaration of `strerror_s' */

I took #cmakedefine01 instead of #cmakedefine ${...}.


> The autoconf part tests for _alloca, __chkstk, etc when the target
> system is MinGW, while on the cmake part the checks are performed when
> LLVM_ON_WIN32 is true, which in practice means MinGW and VC++. I guess
> that those functions are used while compiling with VC++.

Sure, checking such symbols for msvc with cmake would be redundant.
(In fact, no symbols can be found on msvc.)
I think it would be less harmful but I might tighten up condition only
to mingw later.

...Takumi