[llvm-commits] [Review request][Win64] Patches for Mingw-w64(and mingw64-clang)

[Óscar Fuentes]

NAKAMURA Takumi <geek4civic at gmail.com> writes:

> Eric and Oscar,
>
> I reformatted my patchset and attached, thank you.

You still have:

+/* Define to 1 if you have the declaration of `strerror_s', and to 0 if
+   don't. */
+#cmakedefine HAVE_DECL_STRERROR_S ${HAVE_DECL_STRERROR_S}

instead of

+/* Define to 1 if you have the declaration of `strerror_s' */

The autoconf part tests for _alloca, __chkstk, etc when the target
system is MinGW, while on the cmake part the checks are performed when
LLVM_ON_WIN32 is true, which in practice means MinGW and VC++. I guess
that those functions are used while compiling with VC++.

As far as I'm concerned, once you fix the comment on config.h.cmake
mentioned above the patch is ready for svn.