[llvm-commits] [patch][cmake] Fix check for <argz.h>

[Óscar Fuentes]

arrowdodger <6yearold at gmail.com> writes:

>> but anyways what you describe does not
>> seem right to me. The existence of a header does not imply the existence
>> of the functions that *usuallay* that header declares. For the specific
>> case of argz_*, I guess that there is a good reason why the configure
>> script tests for their existence. In any case, your change should target
>> cmake and `configure', not just cmake.
>>
> Now i looked into configure.ac and haven't find any argz checks. But these
> defines appear both in config.h.in and config.h.cmake.

The configure script tests for the presence of the argz_* functions:

checking for argz_append... yes
checking for argz_create_sep... yes
checking for argz_insert... yes
checking for argz_next... yes
checking for argz_stringify... yes

> So, should i just delete all these checks and defines from both builds or
> tweak my current patch as you suggested?

As mentioned above, IMO it is not correct to remove the argz_* tests
just because argz.h exists, unless we know for sure that all platforms
with argz.h have those functions defined.