[llvm-commits] [patch][cmake] Fix check for <argz.h>

Óscar Fuentes ofv at wanadoo.es
Thu Jan 13 05:21:00 PST 2011


arrowdodger <6yearold at gmail.com> writes:

> Here is patch, that fixes checking for argz.h header file in CMake build.
> I decided, that if argz.h is found, then it's safe to suggest, that we have
> all argz_* functions. So, i'm not checking every function' existance.

You forgot to attach the patch, but anyways what you describe does not
seem right to me. The existence of a header does not imply the existence
of the functions that *usuallay* that header declares. For the specific
case of argz_*, I guess that there is a good reason why the configure
script tests for their existence. In any case, your change should target
cmake and `configure', not just cmake.

Eric?




More information about the llvm-commits mailing list