[llvm-commits] [llvm] r122354 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/X86/divide-by-constant.ll

Duncan Sands baldrick at free.fr
Tue Dec 21 12:26:59 PST 2010


Hi Dale,

> Get the type of a shift from the shift, not from its shift
> count operand.  These should be the same but apparently are
> not always, and this is cleaner anyway.  This improves the
> code in an existing test.

IIRC on x86 the shift amount has to be i8 for the operation to be legal, so
might this change cause problems if run after legalization?

Ciao, Duncan.



More information about the llvm-commits mailing list