[llvm-commits] [llvm] r122176 - in /llvm/trunk/lib/CodeGen: PreAllocSplitting.cpp SimpleRegisterCoalescing.cpp TwoAddressInstructionPass.cpp

[Cameron Zwarich]

On 2010-12-19, at 10:11 AM, Jakob Stoklund Olesen wrote:

>> Modified: llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp?rev=122176&r1=122175&r2=122176&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp Sun Dec 19 12:03:27 2010
>> @@ -148,10 +148,8 @@
>>      AU.addPreserved<LiveVariables>();
>>      AU.addPreservedID(MachineLoopInfoID);
>>      AU.addPreservedID(MachineDominatorsID);
>> -      if (StrongPHIElim)
>> -        AU.addPreservedID(StrongPHIEliminationID);
>> -      else
>> -        AU.addPreservedID(PHIEliminationID);
>> +      AU.addPreservedID(StrongPHIEliminationID);
>> +      AU.addPreservedID(PHIEliminationID);
>>      MachineFunctionPass::getAnalysisUsage(AU);
>>    }
> 
> Two-addr will never run after StrongPHIElimination, right? You could just remove it completely.

Good point. I'll do that in a bit.

Cameron