[llvm-commits] [llvm] r122176 - in /llvm/trunk/lib/CodeGen: PreAllocSplitting.cpp SimpleRegisterCoalescing.cpp TwoAddressInstructionPass.cpp

[Jakob Stoklund Olesen]

On Dec 19, 2010, at 10:03 AM, Cameron Zwarich wrote:

> Author: zwarich
> Date: Sun Dec 19 12:03:27 2010
> New Revision: 122176
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=122176&view=rev
> Log:
> Remove some checks for StrongPHIElim. These checks make it impossible to use an
> alternative register allocator that does not require LiveIntervals by specifying
> it on the command-line for a target that has StrongPHIElimination enabled by
> default.
> 
> These checks are pretty meaningless anyways, since StrongPHIElimination and
> PHIElimination are never used at the same time.

Thanks, Cameron.

> Modified: llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp?rev=122176&r1=122175&r2=122176&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp (original)
> +++ llvm/trunk/lib/CodeGen/TwoAddressInstructionPass.cpp Sun Dec 19 12:03:27 2010
> @@ -148,10 +148,8 @@
>       AU.addPreserved<LiveVariables>();
>       AU.addPreservedID(MachineLoopInfoID);
>       AU.addPreservedID(MachineDominatorsID);
> -      if (StrongPHIElim)
> -        AU.addPreservedID(StrongPHIEliminationID);
> -      else
> -        AU.addPreservedID(PHIEliminationID);
> +      AU.addPreservedID(StrongPHIEliminationID);
> +      AU.addPreservedID(PHIEliminationID);
>       MachineFunctionPass::getAnalysisUsage(AU);
>     }

Two-addr will never run after StrongPHIElimination, right? You could just remove it completely.

/jakob

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101219/086d00c3/attachment.bin>