[llvm-commits] [llvm] r120826 - in /llvm/trunk: cmake/config-ix.cmake include/llvm/Config/config.h.cmake lib/Support/Windows/PathV2.inc

[Óscar Fuentes]

Michael Spencer <bigcheesegs at gmail.com> writes:

>>> +if ( LLVM_ON_WIN32 )
>>> +  check_symbol_exists(_chsize_s io.h HAVE__CHSIZE_S)
>>> +endif()
>>
>> Why the `if'? Would be problematic if the macro is defined for other
>> platforms?
>
> No, but it only is used if LLVM_ON_WIN32 is true. I'm fine with
> removing the check.

Thanks. IMO, one should restrict a test to a platform only when it is
known that a positive on another platform is harmful.