[llvm-commits] [llvm] r120826 - in /llvm/trunk: cmake/config-ix.cmake include/llvm/Config/config.h.cmake lib/Support/Windows/PathV2.inc

[Michael Spencer]

On Fri, Dec 3, 2010 at 4:02 PM, Óscar Fuentes <ofv at wanadoo.es> wrote:
> Hello Michael.
>
> "Michael J. Spencer"
> <bigcheesegs at gmail.com> writes:
>
>> Author: mspencer
>> Date: Fri Dec  3 12:48:56 2010
>> New Revision: 120826
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=120826&view=rev
>> Log:
>> Support/FileSystem: Fix MinGW build. It doesn't have _chsize_s.
>
> [snip]
>
>> +if ( LLVM_ON_WIN32 )
>> +  check_symbol_exists(_chsize_s io.h HAVE__CHSIZE_S)
>> +endif()
>
> Why the `if'? Would be problematic if the macro is defined for other
> platforms?

No, but it only is used if LLVM_ON_WIN32 is true. I'm fine with
removing the check.

- Michael Spencer