[llvm-commits] [llvm] r119613 - in /llvm/trunk: include/llvm/MC/MCAsmInfo.h lib/CodeGen/AsmPrinter/DwarfDebug.cpp lib/CodeGen/AsmPrinter/DwarfDebug.h lib/MC/MCAsmInfo.cpp lib/Target/CellSPU/SPUMCAsmInfo.cpp test/CodeGen/X86/unknown-location.ll test/DebugInfo/2010-09-16-EmptyFilename.ll

[Devang Patel]

Rafael,

On Nov 17, 2010, at 6:04 PM, Rafael Espindola wrote:

> Author: rafael
> Date: Wed Nov 17 20:04:25 2010
> New Revision: 119613
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=119613&view=rev
> Log:
> Change CodeGen to use .loc directives. This produces a lot more readable output
> and testing is easier.  A good example is the unknown-location.ll test that
> now can just look for ".loc 1 0 0".  We also don't use a DW_LNE_set_address for
> every address change anymore.
> 
> Modified:
>    llvm/trunk/include/llvm/MC/MCAsmInfo.h
>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h
>    llvm/trunk/lib/MC/MCAsmInfo.cpp
>    llvm/trunk/lib/Target/CellSPU/SPUMCAsmInfo.cpp
>    llvm/trunk/test/CodeGen/X86/unknown-location.ll
>    llvm/trunk/test/DebugInfo/2010-09-16-EmptyFilename.ll
> 
> Modified: llvm/trunk/include/llvm/MC/MCAsmInfo.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCAsmInfo.h?rev=119613&r1=119612&r2=119613&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/MC/MCAsmInfo.h (original)
> +++ llvm/trunk/include/llvm/MC/MCAsmInfo.h Wed Nov 17 20:04:25 2010
> @@ -237,10 +237,6 @@
>     /// HasLEB128 - True if target asm supports leb128 directives.
>     bool HasLEB128;                          // Defaults to false.
> 
> -    /// hasDotLocAndDotFile - True if target asm supports .loc and .file
> -    /// directives for emitting debugging information.
> -    bool HasDotLocAndDotFile;                // Defaults to false.
> -
>     /// SupportsDebugInformation - True if target supports emission of debugging
>     /// information.
>     bool SupportsDebugInformation;           // Defaults to false.
> @@ -410,9 +406,6 @@
>     bool hasLEB128() const {
>       return HasLEB128;
>     }
> -    bool hasDotLocAndDotFile() const {
> -      return HasDotLocAndDotFile;
> -    }
>     bool doesSupportDebugInformation() const {
>       return SupportsDebugInformation;
>     }
> 
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=119613&r1=119612&r2=119613&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Nov 17 20:04:25 2010
> @@ -514,8 +514,7 @@
>   unsigned Line = V.getLineNumber();
>   if (Line == 0)
>     return;
> -  unsigned FileID = GetOrCreateSourceID(V.getContext().getDirectory(),
> -                                        V.getContext().getFilename());
> +  unsigned FileID = GetOrCreateSourceID(V.getContext().getFilename());
>   assert(FileID && "Invalid file id");
>   addUInt(Die, dwarf::DW_AT_decl_file, 0, FileID);
>   addUInt(Die, dwarf::DW_AT_decl_line, 0, Line);

You are dropping directory name here and everywhere else. Is it not needed anymore ?
-
Devang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101130/61988ab1/attachment.html>