<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Rafael,<div><br><div><div>On Nov 17, 2010, at 6:04 PM, Rafael Espindola wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Verdana; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Author: rafael<br>Date: Wed Nov 17 20:04:25 2010<br>New Revision: 119613<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=119613&view=rev">http://llvm.org/viewvc/llvm-project?rev=119613&view=rev</a><br>Log:<br>Change CodeGen to use .loc directives. This produces a lot more readable output<br>and testing is easier. A good example is the unknown-location.ll test that<br>now can just look for ".loc 1 0 0". We also don't use a DW_LNE_set_address for<br>every address change anymore.<br><br>Modified:<br> llvm/trunk/include/llvm/MC/MCAsmInfo.h<br> llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br> llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.h<br> llvm/trunk/lib/MC/MCAsmInfo.cpp<br> llvm/trunk/lib/Target/CellSPU/SPUMCAsmInfo.cpp<br> llvm/trunk/test/CodeGen/X86/unknown-location.ll<br> llvm/trunk/test/DebugInfo/2010-09-16-EmptyFilename.ll<br><br>Modified: llvm/trunk/include/llvm/MC/MCAsmInfo.h<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCAsmInfo.h?rev=119613&r1=119612&r2=119613&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCAsmInfo.h?rev=119613&r1=119612&r2=119613&view=diff</a><br>==============================================================================<br>--- llvm/trunk/include/llvm/MC/MCAsmInfo.h (original)<br>+++ llvm/trunk/include/llvm/MC/MCAsmInfo.h Wed Nov 17 20:04:25 2010<br>@@ -237,10 +237,6 @@<br> /// HasLEB128 - True if target asm supports leb128 directives.<br> bool HasLEB128; // Defaults to false.<br><br>- /// hasDotLocAndDotFile - True if target asm supports .loc and .file<br>- /// directives for emitting debugging information.<br>- bool HasDotLocAndDotFile; // Defaults to false.<br>-<br> /// SupportsDebugInformation - True if target supports emission of debugging<br> /// information.<br> bool SupportsDebugInformation; // Defaults to false.<br>@@ -410,9 +406,6 @@<br> bool hasLEB128() const {<br> return HasLEB128;<br> }<br>- bool hasDotLocAndDotFile() const {<br>- return HasDotLocAndDotFile;<br>- }<br> bool doesSupportDebugInformation() const {<br> return SupportsDebugInformation;<br> }<br><br>Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=119613&r1=119612&r2=119613&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=119613&r1=119612&r2=119613&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br>+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Nov 17 20:04:25 2010<br>@@ -514,8 +514,7 @@<br> unsigned Line = V.getLineNumber();<br> if (Line == 0)<br> return;<br>- unsigned FileID = GetOrCreateSourceID(V.getContext().getDirectory(),<br>- V.getContext().getFilename());<br>+ unsigned FileID = GetOrCreateSourceID(V.getContext().getFilename());<br> assert(FileID && "Invalid file id");<br> addUInt(Die, dwarf::DW_AT_decl_file, 0, FileID);<br> addUInt(Die, dwarf::DW_AT_decl_line, 0, Line);<br></span></blockquote></div><br></div><div>You are dropping directory name here and everywhere else. Is it not needed anymore ?</div><div>-</div><div>Devang</div></body></html>