[llvm-commits] [llvm] r120225 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrCompiler.td test/CodeGen/X86/2009-04-24.ll test/CodeGen/X86/2009-12-11-TLSNoRedZone.ll test/CodeGen/X86/tls

[Chris Lattner]

On Nov 28, 2010, at 4:57 AM, Rafael Espíndola wrote:

> On 27 November 2010 15:56, Anton Korobeynikov <anton at korobeynikov.info> wrote:
>> Hi Rafael,
>> 
>>>     MachineBasicBlock *EmitLoweredTLSCall(MachineInstr *MI,
>>>                                           MachineBasicBlock *BB) const;
>>> 
>>> +    MachineBasicBlock *emitLoweredTLSAddr(MachineInstr *MI,
>>> +                                          MachineBasicBlock *BB) const;
>>> +
>> How's about consistent naming? :)
> 
> I was trying to use the new proposed naming convention and did a bad
> job at it. The attached patch changes this method to use lowercase for
> all local variables.

I don't think this is a good way to go, "MI" is a acronym.  Lets resolve the naming discussion before we change all the code.  Until then, consistency is good. :)

-Chris