[llvm-commits] [Review request] Instcombine: extractvalue from load --> load from gep

[Frits van Bommel]

On Sun, Nov 28, 2010 at 3:52 AM, Frits van Bommel <fvbommel at gmail.com> wrote:
> No, definitely not okay. It inserts the new load at the location of
> the extractvalue instead of the location of the old load. Fixed
> version attached. I'll provide an extra test case once I've had some
> sleep...

So apparently 4 AM is not the best time to try to fix bugs. Who knew?
I forgot to even run the testcase.
That version is even more broken than the one it replaced; it asserts
every time it fires.

Here's the real fix, as well as the promised adjusted testcase that
checks for the original problem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 006-instcombine-extractvalue-load-v3.patch
Type: text/x-patch
Size: 2194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101128/ba16730f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 007-instcombine-extractvalue-load-test-v2.patch
Type: text/x-patch
Size: 3186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101128/ba16730f/attachment-0001.bin>