[llvm-commits] [Review request] Instcombine: extractvalue from load --> load from gep

[Frits van Bommel]

On Sun, Nov 28, 2010 at 1:12 AM, Frits van Bommel <fvbommel at gmail.com> wrote:
> The attached patch teaches -instcombine to shrink a non-volatile load
> if the only user is an extractvalue instruction.
> I also corrected a comment that claimed there was nothing left to do
> for extractvalue instructions :).
>
> Okay to commit?

No, definitely not okay. It inserts the new load at the location of
the extractvalue instead of the location of the old load. Fixed
version attached. I'll provide an extra test case once I've had some
sleep...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 006-instcombine-extractvalue-load-v2.patch
Type: text/x-patch
Size: 2169 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101128/f58b8ea1/attachment.bin>