[llvm-commits] [Review request] CMake: Add the new option "LLVM_LIT_ARGS"

[Óscar Fuentes]

NAKAMURA Takumi <geek4civic at gmail.com> writes:

>> I'm wary by the use of separate_arguments. Why do you need it and why
>> UNIX_COMMAND was chosen?
>
> My intention is simply to separate simple options to list,
> not to separate complex arguments.
> It seems UNIX_COMMAND works fine.
> I may choose whatever works. What would be better?
>
> Without separation, we will see lit.py "-sv --no-progress-bar".

Have you checked that? As far as you add new arguments to LLMV_LIT_ARGS
with

set(LLMV_LIT_ARGS "${LLMV_LIT_ARGS} --another-arg")

(i.e. not using the variable as a list, but as a string) there should be
no problem. Please note that the cmake interpreter expands the
variable's contents *before* the command is constructed. The only way of
falling into the problem you mentioned would be

COMMAND lit.py "${LLMV_LIT_ARGS}"

instead of

COMMAND lit.py ${LLMV_LIT_ARGS}

(or if LLMV_LIT_ARGS contains escaped double quotes at the wrong place)

[snip]

Please test your change after removing `separate_arguments'. If it
works, commit. Else commit the patch as posted to the mailing list.