[llvm-commits] [llvm] r118422 - in /llvm/trunk: lib/Target/ARM/ARMAsmPrinter.cpp lib/Target/ARM/ARMBuildAttrs.h test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll

[Evan Cheng]

On Nov 8, 2010, at 10:41 AM, Jason Kim wrote:

> On Mon, Nov 8, 2010 at 10:37 AM, Anton Korobeynikov
> <anton at korobeynikov.info> wrote:
>> Hi Jason,
>> 
>>> +    if (CPUString != "generic") {
>>> +      if (CPUString == "cortex-a8") {
>> This looks pretty gross. Is it possible to generalize stuff somehow?
>> E.g. via the mapping of CPU names => supported attributes.
> 
> I agree its very gross. I am going to be iterating over this repeatedly.
> I don't yet have a clear understanding of the space of cpu/attributes yet.
> As I get more familiarized with how GNU/as does things, I will be
> refactoring these.
> 
it's also wrong. What about other cpu's which are cortex-a8 variants and later? Do we have to get this patch in now? Can you table it until you have figured out how to match these to subtarget attributes?

Evan

> 
>> 
>> --
>> With best regards, Anton Korobeynikov
>> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits